davidedmundson added inline comments.

INLINE COMMENTS

> OsdSelector.qml:34
> +
> +    onScreenGeometryChanged: {
> +        root.x = screenGeometry.x + (screenGeometry.width - mainItem.width) 
> / 2

Why are we going for this  instead of a binding?

Is it so X and Y remain unset on X?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D28916

To: bport, romangg, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to