apol added a comment.

  I wonder, while this will work with all our uses of DropUrlPatterns, this 
would have been able to work with something like `scheme:/*potato*` which after 
this patch won't work.
  
  In fact, it's called Patterns, not DropUrlWhenStartsWith. I'd appreciate 
feedback from someone else. Code-wise, looks better for sure.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28978

To: ahmadsamir, #plasma, apol
Cc: kde-frameworks-devel, plasma-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

Reply via email to