ngraham created this revision. ngraham added reviewers: VDG, Plasma, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision.
REVISION SUMMARY Somehow the notification pop-up's positioning has never felt quite right to me. When it's in a bottom corner, it blocks the view of the latest messages in chat apps, or the text I'm searching for in Kate. When it's in a top corner, it blocks part of the open app's toolbar or tab bar that I often use. The best place I've found for is in the top-middle, which doesn't block very many of the thing I'm active using, and its centered position feels aesthetically pleasing. I've been using this for a bit and quite like it. However there is ony deficiency: the pop-up is not very wide, so it becomes quite tall when displaying multi-line messages from chat apps in particular, which makes the notification stack intrude into the middle of the screen where it definitely blocks things you want to be looking at. This is annoying. This patch resolves that issue by making the pop-up's size wider and the spacing between pop-ups smaller when the pop-ups are positioned in the top or bottom middle. There is no visual change when the notification pop-up is in one of the corners. TEST PLAN Centered pop-ups now look like this: Single pop-up: F8247020: Screenshot_20200419_110522.png <https://phabricator.kde.org/F8247020> Stack of pop-ups: F8247025: Screenshot_20200419_112511.png <https://phabricator.kde.org/F8247025> REPOSITORY R120 Plasma Workspace BRANCH wider-notification-popu-when-on-top-or-bottom (branched from master) REVISION DETAIL https://phabricator.kde.org/D28989 AFFECTED FILES applets/notifications/package/contents/ui/global/Globals.qml To: ngraham, #vdg, #plasma, broulik Cc: ndavis, cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
