nicolasfella added inline comments. INLINE COMMENTS
> CMakeLists.txt:1 > +project (kcm_mobile_hotspot) > + remove > CMakeLists.txt:11 > + KF5::I18n > + KF5::Plasma > + KF5::QuickAddons KF5::Plasma shouldn't be needed > hotspotsettings.cpp:30 > +{ > + KAboutData* about = new KAboutData("kcm_mobile_hotspot", > i18n("Hotspots"), > + "0.1", QString(), > KAboutLicense::LGPL); Hotspot singular > hotspotsettings.h:32 > + HotspotSettings(QObject *parent, const QVariantList &args); > + virtual ~HotspotSettings(); > +}; override > main.qml:28 > +SimpleKCM { > + id: main > + id is unused. check also for others > main.qml:30 > + > + title: i18n("Hotspot") > + I'm not 100% sure the title is actually getting used REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D29019 To: tfella, #vdg, jgrulich Cc: nicolasfella, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart