----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4236/#review5993 -----------------------------------------------------------
trunk/KDE/kdebase/workspace/libs/plasmaclock/calendartable.cpp <http://reviewboard.kde.org/r/4236/#comment5613> Nope, already existing string, see old line 531 :-) - John On 2010-06-05 00:10:56, John Layt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/4236/ > ----------------------------------------------------------- > > (Updated 2010-06-05 00:10:56) > > > Review request for Plasma. > > > Summary > ------- > > The calendar data engine will now return all holidays along with their > holiday type, i.e. if a day off or not. The calendar plasmoid only shows > days off highlighted in red. In the pop-up only days off are prefixed with > 'Holiday', but all other holidays are now listed. > > I have also changed how Events are displayed. They were shown as a green > highlight with higher priority than a holiday. This caused two issues. > First, information is blocked, it can only show a day is a Holiday or an > Event, it can't show when you have both on the one day. Second, many users > will have Events on almost every day, so almost every day would be green > highlighted, which besides looking ugly and busy also effectively wastes a > high visibility signal on a more common piece of information. Instead I've > gone for the more standard bold day number as done in KOrganizer and most > other calendar programs, and re-used the green highlight for Holidays that > are not days off. > > In the future we could use other options such as cell shading and font > colour, and make it user configurable. > > Screenies attached. > > > This addresses bug 218549. > https://bugs.kde.org/show_bug.cgi?id=218549 > > > Diffs > ----- > > trunk/KDE/kdebase/workspace/libs/plasmaclock/calendartable.h 1134154 > trunk/KDE/kdebase/workspace/libs/plasmaclock/calendartable.cpp 1134154 > > trunk/KDE/kdebase/workspace/plasma/generic/dataengines/calendar/calendarengine.h > 1133276 > > trunk/KDE/kdebase/workspace/plasma/generic/dataengines/calendar/calendarengine.cpp > 1133276 > > Diff: http://reviewboard.kde.org/r/4236/diff > > > Testing > ------- > > Always :-) Note in the second screenie we have Feb 12 with a public holiday > (day off), a commemorative holiday (not a day off), and an event. > > > Screenshots > ----------- > > Calendar Table > http://reviewboard.kde.org/r/4236/s/418/ > Calendar Popup > http://reviewboard.kde.org/r/4236/s/420/ > > > Thanks, > > John > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
