ngraham created this revision. ngraham added reviewers: Plasma, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision.
REVISION SUMMARY I probably introduced the issue fixed here with D29315 <https://phabricator.kde.org/D29315>, sorry. This patch makes the parent layout invisible when all of its children are invisible, so it doesn't keep taking up some vertical space after a previously-visible inhibition goes away. TEST PLAN When an inhibition goes away, it once again looks like it should: F8288112: Screenshot_20200505_203934.png <https://phabricator.kde.org/F8288112> REPOSITORY R120 Plasma Workspace BRANCH collapse-inhibitions-properly (branched from master) REVISION DETAIL https://phabricator.kde.org/D29467 AFFECTED FILES applets/batterymonitor/package/contents/ui/PowerManagementItem.qml To: ngraham, #plasma, broulik Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart