----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4271/ -----------------------------------------------------------
Review request for Plasma. Summary ------- Not sure if it's already too late for 4.5 (hence the review request), but the attached patch fixes two issues: - Newly added URLs that only consist of a path ("/usr/share/[...]" as opposed to "file:///usr/share/[...]") are now resolved into full file-URLs before being passed to KDesktopFile. Among other things, this fixes dragging items from application launcher menus. - The popup dialog now closes automatically after one of it's items is clicked. Whether the previous behavior counts as a bug is probably a matter of perspective, but IMHO it was a bit annoying. Please tell me if I can commit this or if I should wait until trunk reopens. Thanks! Diffs ----- /trunk/KDE/kdebase/workspace/plasma/generic/applets/quicklaunch/icongrid.h 1135692 /trunk/KDE/kdebase/workspace/plasma/generic/applets/quicklaunch/icongrid.cpp 1135692 /trunk/KDE/kdebase/workspace/plasma/generic/applets/quicklaunch/quicklaunch.h 1135692 /trunk/KDE/kdebase/workspace/plasma/generic/applets/quicklaunch/quicklaunch.cpp 1135692 /trunk/KDE/kdebase/workspace/plasma/generic/applets/quicklaunch/quicklaunchicon.cpp 1135692 Diff: http://reviewboard.kde.org/r/4271/diff Testing ------- Thanks, Ingomar _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel