----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4419/#review6212 -----------------------------------------------------------
Ship it! can you also add a comment in the code noting that this is a work-around and what a more correct solution should be (maybe prefix the comment with //FIXME: even) /trunk/KDE/kdebase/workspace/libs/plasmaclock/calendartable.cpp <http://reviewboard.kde.org/r/4419/#comment5801> small ws issue: it should be "} else {" - Aaron On 2010-06-21 06:07:40, Alain Boyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/4419/ > ----------------------------------------------------------- > > (Updated 2010-06-21 06:07:40) > > > Review request for Plasma. > > > Summary > ------- > > This patch is a temporary workaround for bugs 238116 and 224344. I am calling > it temporary since it is my understanding that the drawing of the calendar > applet will be worked on and improved for 4.6. Is this correct? > > Basically, only one week number is shown when there is not enough room to > display two week numbers in the calendar applet (two week numbers are > displayed when the first day of the week is not Monday). Instead of simply > displaying the first week number, an attempt is made to display the week > number that has the most amount of days in the calendar row. > > > Diffs > ----- > > /trunk/KDE/kdebase/workspace/libs/plasmaclock/calendartable.cpp 1140389 > > Diff: http://reviewboard.kde.org/r/4419/diff > > > Testing > ------- > > Tested with Georgian calendar and seems to give correct behavior no matter > which day of the week is set as the first day of the week. > > Needs testing with other calendars and RTL layouts. > > > Thanks, > > Alain > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
