kossebau added inline comments.


> kmaterka wrote in systemtray.h:100
> I don't know, this code was there before my changes, I've just done some 
> refactoring here.

Thanks for your reply. Okay, so seems you did not hit anything related.

Thing is, you added
Q_INVOKABLE Plasma::Service *serviceForSource(const QString &source);

  here, whereas the JavaScript code before was calling serviceForSource() on a 
Plasma::DataSource class, which does not return the type "Plasma::Service *", 
but "QObject *", cmp. its method definition

Q_INVOKABLE QObject *serviceForSource(const QString &source);

  and the JavaScript engine for a plain QObject simply exposes any Q_INVOKABLEs 
and slot methods, that's why no extra registration would be needed (AFAIK).
  So still a mystery to me why this here seems to work, too bad :)

  R120 Plasma Workspace


To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, ngraham, broulik
Cc: kossebau, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to