One big fix is fine IMO.
Nate
On 11/9/20 6:53 AM, Konrad Materka wrote:
Aleix,
Yes, I know frameworks have lower dependencies - I just wanted to fix
QML warnings in Plasma Workspace. The question is:
Is it OK to do this in one bug change, or should I split it into smaller?
Konrad
pon., 9 lis 2020 o 14:23 Aleix Pol <aleix...@kde.org
<mailto:aleix...@kde.org>> napisał(a):
Hi Konrad,
It's okay to fix them in Plasma. Most of the ones we still have though
are in frameworks that still depend on Qt 5.12 and it's not trivial to
address this problem over there.
Aleix
On Mon, Nov 9, 2020 at 10:25 AM Konrad Materka <mate...@gmail.com
<mailto:mate...@gmail.com>> wrote:
>
> Hi,
>
> With Qt 5.15 we have tons of warnings like:
> QML Connections: Implicitly defined onFoo properties in
Connections are deprecated.
>
> Qt 5.15 is now a minimum requirement for Plasma Workspace, so
nothing is blokcking to migrate to new syntax.
>
> Is it OK to fix them in one massive MR or better to do that one
by one (I mean one applet/module at a time)?
