davidre added inline comments.

INLINE COMMENTS

> filipf wrote in sddmkcm.cpp:243
> Unfortunately not yet because we still need the `kdeglobals` file for color 
> schemes. From my previous testing it's not enough to just copy some line 
> `colorScheme=Adwaita`, we actually need to copy all of the color scheme 
> values written in `kdeglobals`. IIRC that was also a bit tricky just like 
> recreating the `fonts.conf` XML file, but it may be possible to reuse 
> existing KDE color scheme functions instead of copy-pasting from config files.

Alright

BRANCH
  arcpatch-D23257

REVISION DETAIL
  https://phabricator.kde.org/D23257

To: filipf, ngraham, #plasma, davidedmundson
Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to