----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4867/#review6800 -----------------------------------------------------------
Ship it! looks good :) (you don't have an svn account, correct? will you be continuing to work on paches for KDE? if so, we could get you your own svn account and you could help maintain the 15 puzzle plasmoid and others. if you're just trying to get your pet peeves fixed in fifteenpuzzle, then i can commit these for you :) - Aaron On 2010-08-04 18:41:05, Alex Raymond wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/4867/ > ----------------------------------------------------------- > > (Updated 2010-08-04 18:41:05) > > > Review request for Plasma and Aaron Seigo. > > > Summary > ------- > > Previously, the initial piece arrangement for the fifteenPuzzle was: > > - 1 2 3 > 4 5 6 7 > 8 9 10 11 > 12 13 14 15 > > This arrangement makes the puzzle unsolvable. So the correct initial position > must be with the empty space on the last tile, instead of the first. > > > Diffs > ----- > > /trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/fifteen.cpp 1159207 > /trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/piece.h 1159207 > /trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/piece.cpp 1159207 > > Diff: http://reviewboard.kde.org/r/4867/diff > > > Testing > ------- > > > Thanks, > > Alex > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
