----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5329/#review7582 -----------------------------------------------------------
Ship it! looks great; and it shows a problem in ConfigLoader -> it should be using int, not qint32 for the integer list. nice! :) - Aaron On 2010-09-13 17:51:03, Martin Blumenstingl wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5329/ > ----------------------------------------------------------- > > (Updated 2010-09-13 17:51:03) > > > Review request for Plasma. > > > Summary > ------- > > Currently I'm changing some of the code in Plasma::ConfigLoader. > I want to make sure that I don't break that much ;) > > Thus I wrote a unit test for the config loader. > Currently all it does it testing if the config loader can parse the > default-values correctly. > One test for each (data-)"type" which ConfigLoader can handle. > > > Diffs > ----- > > /trunk/KDE/kdelibs/plasma/tests/configloadertest.xml PRE-CREATION > /trunk/KDE/kdelibs/plasma/tests/CMakeLists.txt 1174512 > /trunk/KDE/kdelibs/plasma/tests/configloadertest.h PRE-CREATION > /trunk/KDE/kdelibs/plasma/tests/configloadertest.cpp PRE-CREATION > > Diff: http://svn.reviewboard.kde.org/r/5329/diff > > > Testing > ------- > > I ran the tests on my box. > All of them were successful. > > > Thanks, > > Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel