----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5529/#review7992 -----------------------------------------------------------
for the plasma part i'm ok. would be possible to use this effect also when starting applications in other ways? (start menu, dolphin, whatever) - Marco On 2010-10-06 08:44:46, Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5529/ > ----------------------------------------------------------- > > (Updated 2010-10-06 08:44:46) > > > Review request for kwin, Plasma and Lubos Lunak. > > > Summary > ------- > > Implemented an OpenGL based Startup Feedback effect to replace the > functionality provided by StartupId in KRunner when effects are available. > The effect supports the three modes bouncing, blinking and passive in exactly > the same way as the current existing functionality. > > Using an effect has several advantages: > * we do not need to remove the alpha channel from the icons > * no need to move windows around, shape and raise them > * no need to prepare several pixmaps for blinking mode as OpenGL provides > the same functionality using texture modulation (have I ever mentioned that I > hate texture modulation?) > > The effect is completely controlled by KRunner through DBus, when a startup > is added the effect get's activated, when the last current startup is removed > the effect gets deactivated again. The DBus call has to pass the type > (bouncing, blinking or passive) and the icon name to the effect. > > > Diffs > ----- > > trunk/KDE/kdebase/workspace/kcontrol/launch/CMakeLists.txt 1174006 > trunk/KDE/kdebase/workspace/kcontrol/launch/interface_util.h PRE-CREATION > trunk/KDE/kdebase/workspace/kcontrol/launch/kcmlaunch.cpp 1174006 > trunk/KDE/kdebase/workspace/krunner/startupid.h 1182634 > trunk/KDE/kdebase/workspace/krunner/startupid.cpp 1182634 > trunk/KDE/kdebase/workspace/kwin/effects/CMakeLists.txt 1182656 > trunk/KDE/kdebase/workspace/kwin/effects/startupfeedback/CMakeLists.txt > PRE-CREATION > trunk/KDE/kdebase/workspace/kwin/effects/startupfeedback/startupfeedback.h > PRE-CREATION > > trunk/KDE/kdebase/workspace/kwin/effects/startupfeedback/startupfeedback.cpp > PRE-CREATION > > trunk/KDE/kdebase/workspace/kwin/effects/startupfeedback/startupfeedback.desktop > PRE-CREATION > > Diff: http://svn.reviewboard.kde.org/r/5529/diff > > > Testing > ------- > > * StartupId uses KWin effect when effect is present > * Changing mode works > * StartupId uses "legacy" window when effect is not present. > > > Thanks, > > Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
