> On 2010-10-12 08:23:52, Marco Martin wrote: > > sounds good, you should check if a phone application is available at all > > before showing the action tough > > Bart Visscher wrote: > There is no function to check in Akonadi. But it is still useful because > it displays the number and you can dial it with another phone. > > > Marco Martin wrote: > how it does display it? is it a popup window? a notification? > > Marco Martin wrote: > can you talk about it to akonady people? (or even just file a bug) > also, i wondoer if a function like that wouldn't belong to > KToolInvocation...
The number is displayed as an extra line in the results. I just had a look at KToolInvocation, it also doesn't have a function to check if there is a browser or mail program available. But moving this code to KToolInvocation or some other place is a good idea. - Bart ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5604/#review8085 ----------------------------------------------------------- On 2010-10-12 21:13:20, Bart Visscher wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5604/ > ----------------------------------------------------------- > > (Updated 2010-10-12 21:13:20) > > > Review request for Plasma. > > > Summary > ------- > > When a contact has a phonenumber add an action to display/call this contact. > > > Diffs > ----- > > /trunk/KDE/kdeplasma-addons/runners/contacts/CMakeLists.txt 1182509 > /trunk/KDE/kdeplasma-addons/runners/contacts/contactsrunner.cpp 1182509 > > Diff: http://svn.reviewboard.kde.org/r/5604/diff > > > Testing > ------- > > search for a contact and activated the call action > > > Thanks, > > Bart > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
