----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5747/ -----------------------------------------------------------
(Updated 2010-11-01 18:42:29.964037) Review request for Plasma. Changes ------- Added the option to disable the shadow (not all colour choices look right with a shadow: specifically, on my desktop with a translucent panel, it looks bad with anything except white text and no shadow). Note that all translucency of text is now disabled if the shadow is not drawn. Summary ------- Since the shadow was introduced for the digital clock a few weeks ago, the custom colour setting has been ignored. This re-enables it, and also allows the user to choose a shadow colour. This changes the configuration dialog and introduces a new option, which is why I'm submitting it for review before committing. Diffs (updated) ----- /trunk/KDE/kdebase/workspace/plasma/generic/applets/digital-clock/clock.h 1191270 /trunk/KDE/kdebase/workspace/plasma/generic/applets/digital-clock/clock.cpp 1191270 /trunk/KDE/kdebase/workspace/plasma/generic/applets/digital-clock/clockConfig.ui 1191270 Diff: http://svn.reviewboard.kde.org/r/5747/diff Testing ------- Changing, saving and loading the settings worked in plasmoid-viewer. Thanks, Alex
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
