> On 2010-11-15 13:05:46, Aaron Seigo wrote: > > is there a need for the underscore, or for being able to configure it? > > would it be enough to just check if there is more than one word after > > "spell", check if that's a valid dictionary and if so use it? that would > > lead to imho the more natural grammar of "spell hello", "spell en hello", > > "spell de Kraul". > > > > being able to write "spell german Kraul" would be really nice (prevents the > > user from having to know the language codes) but perhaps asking too much > > from the runner :)
In general there is no need to specify the underscore, the only reason I did this is in the case that underscores aren't present on the users' keyboard. But as you suggest just using a space would be better and also simplify the code. On the other suggestion, yeah I thought about that. Though I am not sure if all language-names are translated to all languages, i.e. if you have to enter "German" or "deutsch". Because imo it would be most comfortable to enter the language-name in the set locale. - Matthias ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5849/#review8736 ----------------------------------------------------------- On 2010-11-15 12:45:41, Matthias Fuchs wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5849/ > ----------------------------------------------------------- > > (Updated 2010-11-15 12:45:41) > > > Review request for Plasma and Ryan Bitanga. > > > Summary > ------- > > Feature for 4.7 > > As the summary says, this patch allows to define which dictionary the spell > check runner should use. "spell" will always use the default one. > "spell_de" or more specifically "spell_de_DE" would work now. > > > Diffs > ----- > > /trunk/KDE/kdeplasma-addons/runners/spellchecker/spellcheck.h 1197278 > /trunk/KDE/kdeplasma-addons/runners/spellchecker/spellcheck.cpp 1197278 > /trunk/KDE/kdeplasma-addons/runners/spellchecker/spellcheck_config.h > 1197278 > /trunk/KDE/kdeplasma-addons/runners/spellchecker/spellcheck_config.cpp > 1197278 > /trunk/KDE/kdeplasma-addons/runners/spellchecker/spellcheck_config.ui > 1197278 > > Diff: http://svn.reviewboard.kde.org/r/5849/diff > > > Testing > ------- > > > Thanks, > > Matthias > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
