> On 2010-12-04 17:29:39, Aaron Seigo wrote: > > i think it does need a string to explain, because unless one understands > > _why_ it is doing such a thing it could appear pretty "magical". imho this > > is something that can wait for 4.7 because, while odd and perhaps even > > annoying, it doesn't result in any data loss. a simple "Select one or more > > items from the list below" string would probably help a lot. my other > > concern with putting this in without a string is that, with the bug fixed, > > we will forget to go in and add the string when we're open for string > > freeze. all imho.
i see your point. I will try to fix my page and if you validate i will commit when 4.7 will open. Thanks for your review - Nicolas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6041/#review9129 ----------------------------------------------------------- On 2010-12-04 15:00:02, Nicolas Lécureuil wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6041/ > ----------------------------------------------------------- > > (Updated 2010-12-04 15:00:02) > > > Review request for Plasma. > > > Summary > ------- > > When the user ask to show no buttons in the lockout widget, nothing tell the > user that this is not possible, and when he saves the configuration nothing > changed in the widget. > > With this patch, if the user unselect all the checkboxes, he is warned. > > > This addresses bug 256879. > https://bugs.kde.org/show_bug.cgi?id=256879 > > > Diffs > ----- > > trunk/KDE/kdebase/workspace/plasma/generic/applets/lock_logout/lockout.h > 1202613 > trunk/KDE/kdebase/workspace/plasma/generic/applets/lock_logout/lockout.cpp > 1202613 > > Diff: http://svn.reviewboard.kde.org/r/6041/diff > > > Testing > ------- > > > Thanks, > > Nicolas > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
