> On Feb. 10, 2011, 4:53 p.m., John Layt wrote: > > Good idea, but not quite the right approach. I want to keep the internal > > implementation of the widget completely hidden from any clients, allowing > > it to be completely changed in the future if needs be, so exposing the > > QTreeWidgetItem signal is wrong for that, as would be exposing teh int > > version too (after all the client has no idea what those mean). Instead, > > simply add a new public slot for itemChanged() without any parms, then > > anyone connecting to it can use the proper api to find out what the new > > selection is. > > John Layt wrote: > Actually, make that selectionChanged() instead, more generic name. > > John Layt wrote: > And by slot I mean signal :-) Need coffee...
Done. Check it out please. - Romário ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100619/#review1342 ----------------------------------------------------------- On Feb. 12, 2011, 4:40 a.m., Romário Rios wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100619/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2011, 4:40 a.m.) > > > Review request for KDEPIM-Libraries and Plasma. > > > Summary > ------- > > Makes HolidayRegionSelector emit a signal when something is modified in the > widget. Needed for enabling Apply button on plasmaclock config > [http://git.reviewboard.kde.org/r/100620/]. > > > Diffs > ----- > > kholidays/holidayregionselector.h a48823e > kholidays/holidayregionselector.cpp 6115b2f > > Diff: http://git.reviewboard.kde.org/r/100619/diff > > > Testing > ------- > > Works fine so far, although I'm not sure if the naming is OK. > > > Thanks, > > Romário > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel