> On March 4, 2011, 4:02 p.m., Aaron J. Seigo wrote: > > nice idea :) > > > > there is a string translation (localization) issue on lines 615-617 and a > > handful of whitespace issues. once those are addressed, please commit. > > J Janz wrote: > * On strings, some thoughts: > > - For the options, "No title" or, maybe better, just "None" is more > explicit about what's going to happen than "Empty" (you'll end up with no > title and not an empty space) and, possibly, "title" is redundant in "Default > title" option (you're setting the title, so "Default" should do it); and > > - Maybe there's no more point on keeping the "Custom" in the label (I > suggest dropping it and leaving it just as "Title", since you're actually > setting the options for the title rather than just customizing its text). > > * On the (agreed, great) idea for the widget, if it's an editable > combobox (that is, if the options don't come up only if the user types > something, less discoverable) the user can, instead of exclusively typing, > always just open the drop-down-list of options and choose one of the three > or, then, type anything he wants in place. > > Farhad Hedayati Fard wrote: > I agree J! Thanks for your nice opinions :) > I think that the current completion box is a little bit ugly, IMHO It's > better to create a custom widget for this rather than using KLineEdit with > completionbox (maybe inherit from QComboBox?). > > Aaron, Sebastian, please let me know if you think this is OK so that I > start implementing the widget! ;) > > Thanks > > J Janz wrote: > Farhad, I don't think there's a need for a custom widget: KComboBox have > autoCompletion (never looked for it before, Qt Designer to the rescue =) ) ...
I edited the texts (Default title to Default and Empty to None) and fixed the problems that Aaron mentioned, But I don't know how to do the Combobox combined with lineEdit using KComboBox... I'm going to push my changes, But I'll try to change the KLineEdit to something more appropriate that is somehow like KComboBox with a lineEdit and autocomplete and create another review request for that :) - Farhad ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100750/#review1761 ----------------------------------------------------------- On March 3, 2011, 1:39 p.m., Farhad Hedayati Fard wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100750/ > ----------------------------------------------------------- > > (Updated March 3, 2011, 1:39 p.m.) > > > Review request for Plasma. > > > Summary > ------- > > Let the user set a blank label. The label should not take up any space when > it is blank. > > > Diffs > ----- > > plasma/applets/folderview/folderview.h 2241b12 > plasma/applets/folderview/folderview.cpp f604277 > > Diff: http://git.reviewboard.kde.org/r/100750/diff > > > Testing > ------- > > Works fine here! > > > Screenshots > ----------- > > folderview configuration dialog > http://git.reviewboard.kde.org/r/100750/s/84/ > folderview with blank label > http://git.reviewboard.kde.org/r/100750/s/85/ > > > Thanks, > > Farhad > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
