----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100834/#review1887 -----------------------------------------------------------
plasma/applets/folderview/folderview.cpp <http://git.reviewboard.kde.org/r/100834/#comment1561> Whitespace :) - Shaun On March 10, 2011, 10:23 a.m., Farhad Hedayati Fard wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100834/ > ----------------------------------------------------------- > > (Updated March 10, 2011, 10:23 a.m.) > > > Review request for Plasma. > > > Summary > ------- > > IMO and As J Janz said in my previous review, using an editable KComboBox > instead of a KLineEdit with completion box is a cleaner and less confusing > approach for letting the user choose one of the predefined values for the > title bar in the folderview's config dialog. I've edited the UI file and > replaced the KLineEdit with a KComboBox, and used a KLineEdit for the > LineEdit of this combobox as QLineEdit doesn't provide the clickMessage afaik. > > > Diffs > ----- > > plasma/applets/folderview/folderview.h ef4e205 > plasma/applets/folderview/folderview.cpp 67f9ec0 > plasma/applets/folderview/folderviewDisplayConfig.ui 6568640 > > Diff: http://git.reviewboard.kde.org/r/100834/diff > > > Testing > ------- > > Compiled and tested this patch, works fine here. > > > Thanks, > > Farhad > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
