----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100846/#review1920 -----------------------------------------------------------
Ship it! - Aaron J. On March 12, 2011, 2:58 p.m., Elvis Stansvik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100846/ > ----------------------------------------------------------- > > (Updated March 12, 2011, 2:58 p.m.) > > > Review request for Plasma. > > > Summary > ------- > > Hey guys. My first patch for plasma, so might be a bit rough. Suggestions > welcome. > > Hardware temperature sensors are often off by +/- a degrees from the actual > temperature. This patch lets the user configure a constant offset for each > temperature reading to compensate for this. > > See attached screenshot. > > > Diffs > ----- > > plasma/generic/applets/system-monitor/CMakeLists.txt > b160c2f1ffaf2b02df688c9e736599cde98e21d3 > plasma/generic/applets/system-monitor/temperature-offset-delegate.h > PRE-CREATION > plasma/generic/applets/system-monitor/temperature-offset-delegate.cpp > PRE-CREATION > plasma/generic/applets/system-monitor/temperature.h > 049a80f9394b05b3f121a58fa200f99ce61f5ea0 > plasma/generic/applets/system-monitor/temperature.cpp > 16f06aa04c16eb1595cdbc79138c7ed0519c47dc > > Diff: http://git.reviewboard.kde.org/r/100846/diff > > > Testing > ------- > > - The temperatures in the visualization are correctly offset by the > configured offsets. > - The offsets are correctly saved to plasma-desktop-appletsrc. > > > Screenshots > ----------- > > The UI for changing temperature offsets. > http://git.reviewboard.kde.org/r/100846/s/97/ > > > Thanks, > > Elvis > >
_______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
