> On June 27, 2011, 11:51 a.m., Aaron J. Seigo wrote: > > looks good, minus the two small memory leaks; i'm not as convinced that the > > direction of the timeline is "correct" but let's keep it this way for now. > > after fixing the two memory leaks, please commit... cheers :)
Yes, i am not convinced myself;) Putting the timelineitems in a separate scrollbar could do the trick. But i'll try that in an other branch. Thanks for your time. Etienne - Etienne ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101728/#review4196 ----------------------------------------------------------- On June 25, 2011, 10:01 p.m., Etienne Rebetez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101728/ > ----------------------------------------------------------- > > (Updated June 25, 2011, 10:01 p.m.) > > > Review request for Plasma. > > > Summary > ------- > > Hi, > > When trying out plasmate the last day, i was hit with the bug 276082. Since i > didn't want that it happens to someone else, i made a fix for it. > I the process i found that the loadTimeLine function was far to big. So i did > also some refactoring. (this diff is kinda huge but i made the changes in a > branch which i can merge to master) > The timeliene and savepoint creation should now behave as expected. > > Let me know what you think. > Etienne > > PS: How is the commit policy in plasmate? Could i just push directly to > master in the future? > > > Diffs > ----- > > mainwindow.cpp 8326a29 > savesystem/tablewidget.cpp 39e8761 > savesystem/timeline.h 719fb73 > savesystem/timeline.cpp d258a1a > savesystem/timelineitem.h 1e9699f > savesystem/timelineitem.cpp d9b0a67 > > Diff: http://git.reviewboard.kde.org/r/101728/diff > > > Testing > ------- > > > Thanks, > > Etienne > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
