----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101916/#review4605 -----------------------------------------------------------
mainwindow.cpp <http://git.reviewboard.kde.org/r/101916/#comment4021> Why the author did m_part=0; etc. projectmanager/projectmanager.cpp <http://git.reviewboard.kde.org/r/101916/#comment4022> Why in general the destructors of plasmate doesn't do something like that?? - Giorgos On July 11, 2011, 6:12 p.m., Giorgos Tsiapaliwkas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101916/ > ----------------------------------------------------------- > > (Updated July 11, 2011, 6:12 p.m.) > > > Review request for Plasma. > > > Summary > ------- > > hello, > > I was looking at the projectmanager.projectmanager.[h/cpp] and i noticed that > there wasn't no destructor. > The patch adds a destructor at projectmanager and changed a bit the > mainwindow.cpp. > > I have some question in my next reply > > > Diffs > ----- > > mainwindow.cpp e08581f > projectmanager/projectmanager.h 53ef226 > projectmanager/projectmanager.cpp 122e48d > > Diff: http://git.reviewboard.kde.org/r/101916/diff > > > Testing > ------- > > compiles fine and no pointer error > > > Thanks, > > Giorgos > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
