----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102290/#review6441 -----------------------------------------------------------
editors/editpage.cpp <http://git.reviewboard.kde.org/r/102290/#comment5713> KFileDialog::getOpenUrls() is a static function, so it doesn't use 'imageDialog' which you have just constructed. You need to remove the previous line and call KFileDialog::getOpenUrls() with suitable parameters. - David On Aug. 10, 2011, 6:29 p.m., Giorgos Tsiapaliwkas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102290/ > ----------------------------------------------------------- > > (Updated Aug. 10, 2011, 6:29 p.m.) > > > Review request for Plasma and Aaron J. Seigo. > > > Summary > ------- > > hello, > > without this patch a user cannot add an image with plasmate. > > reproduce,go to files-images-new,the plasmate will open a text editor instead > of a dialog,which(the dialog) is able to open an image. > > With the patch a dialog will open asking for an image. > > > Diffs > ----- > > editors/editpage.h 7b5dca3 > editors/editpage.cpp d4b0082 > packagemodel.cpp 8c0907a > > Diff: http://git.reviewboard.kde.org/r/102290/diff > > > Testing > ------- > > the patch is not ready yet,i have noted some questions. > Also the plasmate tries to open the image with a text editor.This have to be > fixed,but how?Should we make plasmate able to preview images? > > In addition,when you add something in the list of files(using the different > options provided by the files qdockwidget) it names it as "new".This has to > be fixed and the plasmate has to show the real name of the file.(different > request,i just want an approval for this patch). > > > Thanks, > > Giorgos > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
