----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102621/#review6545 -----------------------------------------------------------
i find having the date on a line by itself very hard to read (due to no visual cue as to what information belongs with what city). i'd prefer it to remain on line (and not split == great!) - Aaron J. On Sept. 15, 2011, 3:41 p.m., Jaime Torres Amate wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102621/ > ----------------------------------------------------------- > > (Updated Sept. 15, 2011, 3:41 p.m.) > > > Review request for Plasma. > > > Summary > ------- > > The first version of this patch only: > * allows Qt to split the date in the spaces, avoiding the split in the year. > * removes a <table> that makes the rendering harder > * adds a <br> to include an space between the dates and the event. > > The second verion of this patch does: > * changes the table to show the city and time in one line and the date, in > another line, always complete. > * removes a <table> that makes the rendering harder > * adds a <br> to include an space between the dates and the event. > > Look at the screnshot. > > Can remove the <br>, leave it, or add another before the table of cities. > > > This addresses bug 260394. > http://bugs.kde.org/show_bug.cgi?id=260394 > > > Diffs > ----- > > libs/plasmaclock/clockapplet.cpp b1275af > > Diff: http://git.reviewboard.kde.org/r/102621/diff > > > Testing > ------- > > Checked with zero, one and several timezones with short and large city names > in two machines. > > > Screenshots > ----------- > > version 2 > http://git.reviewboard.kde.org/r/102621/s/262/ > > > Thanks, > > Jaime Torres > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
