----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102824/#review7463 -----------------------------------------------------------
Sorry for the late reply. First of all notice that there is a complete qml rewrite of the device notifier which could make it for 4.8. I still don't know if it will be the case, so, I'll review your patch in any case. I kind of remember that the call to activate() was indeed useful, but I have to recollect my memories, which unfortunately doesn't happen right now. I'll have a more in-depth look. Please bear with me a bit more; spare time is very scarce in these days. - Jacopo De Simoi On Oct. 11, 2011, 10:18 a.m., Simon Persson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102824/ > ----------------------------------------------------------- > > (Updated Oct. 11, 2011, 10:18 a.m.) > > > Review request for Plasma, Giulio Camuffo and Jacopo De Simoi. > > > Description > ------- > > This is my first fix for plasma, maybe there's a reason to emit > plasma::applet::activated() that I don't know. Removing it fixes the problem > and I can't see any regression. > I also needed to remove activated() signal from NotifierDialog, I consider > this one to be unnecessary since there is an eventfilter that on > QEvent::GraphicsSceneHoverMove triggers the popup to be open for 7.5 s more. > In other words, the popup will now close after 7.5 s of inactive mouse if it > was shown as a result of plugging in a device... which I guess was the > intended behavior. > > Couldn't actually find any open bug report for this. (!) > > > Diffs > ----- > > plasma/generic/applets/devicenotifier/notifierdialog.cpp dff38d9 > plasma/generic/applets/devicenotifier/notifierdialog.h 8a03fc5 > plasma/generic/applets/devicenotifier/devicenotifier.cpp b9dfce5 > > Diff: http://git.reviewboard.kde.org/r/102824/diff/diff > > > Testing > ------- > > > Thanks, > > Simon Persson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
