On Friday, October 14, 2011 05:19:09 John Stanley wrote: > Hi, > I submitted a patch which hopefully fixes Bug > https://bugs.kde.org/show_bug.cgi?id=275469), > which may be related to this issue (see Comment #50). The patch is > short, so here it is: > > --- kde-workspace-4.7.2.old/libs/taskmanager/taskitem.cpp > 2011-05-20 16:32:08.000000000 -0400 > +++ kde-workspace-4.7.2.new/libs/taskmanager/taskitem.cpp > 2011-10-14 02:23:33.473139259 -0400 > @@ -69,7 +69,6 @@ TaskItem::TaskItem(QObject *parent, Star > > TaskItem::~TaskItem() > { > - emit destroyed(this);
there is a reason it is emitted in the dtor of TaskItem and not simply relying on QObject to do it: the QObject signal happens too late for some parts of the code which rely on it still being a TaskItem*. so this part is incorrect. > //kDebug(); > /* if (parentGroup()){ > parentGroup()->remove(this); > @@ -99,7 +98,7 @@ void TaskItem::setTaskPointer(TaskPtr ta > d->task = task.data(); > connect(task.data(), SIGNAL(changed(::TaskManager::TaskChanges)), > this, SIGNAL(changed(::TaskManager::TaskChanges))); > - connect(task.data(), SIGNAL(destroyed()), this, > SLOT(deleteLater())); > + connect(task.data(), SIGNAL(destroyed(QObject*)), this, > SLOT(taskDestroyed())); this is, however, correct, and was already commited in 4dedf3ce on July 31. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel