----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102878/#review7604 -----------------------------------------------------------
a different approach to this problem can be found in this review: https://git.reviewboard.kde.org/r/102944/ it's a good solution that resolves a number of issues (though limiting the flexibility i suppose?) so i'll mark this one as discarded in favor of 102944. thanks for the patches and comments everyone! :) - Aaron J. Seigo On Oct. 15, 2011, 10:38 p.m., Trever Fischer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102878/ > ----------------------------------------------------------- > > (Updated Oct. 15, 2011, 10:38 p.m.) > > > Review request for Plasma. > > > Description > ------- > > Does pretty much what it says on the tin. > > No more strings that say "2th". Fixed to handle 1st, 2nd, 3rd, 282nd, 12th, > etc. > > Brought up by this reddit thread: > http://www.reddit.com/r/linux/comments/ld8ow/really_kde/ > > > Diffs > ----- > > libs/plasmaclock/clockapplet.h ed6230f > libs/plasmaclock/clockapplet.cpp 4f16cb1 > > Diff: http://git.reviewboard.kde.org/r/102878/diff/diff > > > Testing > ------- > > Spun the spinbox. > > > Thanks, > > Trever Fischer > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
