> On Oct. 25, 2011, 12:48 p.m., Aaron J. Seigo wrote: > > plasma/desktop/applets/tasks/taskgroupitem.cpp, line 1039 > > <http://git.reviewboard.kde.org/r/102833/diff/1/?file=38602#file38602line1039> > > > > watch the indentation level :)
ouch, will fix that before merging. > On Oct. 25, 2011, 12:48 p.m., Aaron J. Seigo wrote: > > plasma/desktop/applets/tasks/taskgroupitem.cpp, lines 1037-1038 > > <http://git.reviewboard.kde.org/r/102833/diff/1/?file=38602#file38602line1037> > > > > i wonder what happens here when you drag an entry from one tasks widget > > to another? :) Well in that case the corresponding entry moves even in the other tasks widget, which is the same behavior as earlier. I'm not sure if thats a problem, is it? - Shantanu Tushar ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102833/#review7601 ----------------------------------------------------------- On Oct. 11, 2011, 6:19 p.m., Shantanu Tushar Jha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102833/ > ----------------------------------------------------------- > > (Updated Oct. 11, 2011, 6:19 p.m.) > > > Review request for Plasma. > > > Description > ------- > > Right now, if the user sets the Task Manager sorting to "manually", its > possible to arrange the task items manually. However, the items move only > after the mouse button is released. > This patch makes the items move dynamically and follow the mouse, this helps > to produce a more natural effect. Check the attached video for a demo. > > > Diffs > ----- > > plasma/desktop/applets/tasks/taskgroupitem.h 7ca95ef > plasma/desktop/applets/tasks/taskgroupitem.cpp 14053d6 > > Diff: http://git.reviewboard.kde.org/r/102833/diff/diff > > > Testing > ------- > > Works perfectly in both horizontal and vertical configurations, and multiple > rows. I didn't find any side-effects. > > > Thanks, > > Shantanu Tushar Jha > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
