> On Oct. 25, 2011, 11:35 a.m., Aaron J. Seigo wrote: > > applets/frame/slideshow.cpp, lines 221-222 > > <http://git.reviewboard.kde.org/r/102817/diff/1/?file=38475#file38475line221> > > > > much cleaner than this, which introduces an assumption on where potd > > stores things into the widget, would be add a URL item in the potd > > DataEngine that is included with the source. this could be either a remote > > or a local URL and wouldn't require the applet to be changed if/when the > > DataEngine changes. > > Greg T wrote: > Well, I get the basic idea but can you try to explain it a little bit > more in detail? I suppose I should make a change in > kdeplasma-addons/dataengines/potd/potd.cpp? > > Aaron J. Seigo wrote: > yes, a change in the dataengine .. so that when it doest setData( > provider->identifier(), provider->image() ) it will also do a > setData(provider->identifier(), "URL", someUrlToTheImage) > > in fact, i'd even change that first setData to be > setData(rovider->identifier(), "Image", provider->image()) and then change > the plasmoid to work with that. if there were other potential users of this > dataengine, it could also be moved into kde-workspace (i could imagine a > wallpaper using it, for instance :)
Thank you, mastermind ;) I chose option 1 but the KStandardDirs::locate stuff is still there. I assume this isn't right? - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102817/#review7597 ----------------------------------------------------------- On Oct. 28, 2011, 10:20 a.m., Greg T wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102817/ > ----------------------------------------------------------- > > (Updated Oct. 28, 2011, 10:20 a.m.) > > > Review request for Plasma. > > > Description > ------- > > Hi, > This fix passes m_currentUrl the correct file path, so the downloaded picture > will be opened by the picture viewer (gwenview). > > > This addresses bug 280406. > http://bugs.kde.org/show_bug.cgi?id=280406 > > > Diffs > ----- > > applets/frame/slideshow.cpp 116c514 > dataengines/potd/potd.cpp f1b9933 > > Diff: http://git.reviewboard.kde.org/r/102817/diff/diff > > > Testing > ------- > > Bug fixed. > > > Thanks, > > Greg T > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
