> On Sept. 30, 2011, 12:39 p.m., Aaron J. Seigo wrote:
> > startpage.cpp, lines 557-562
> > <http://git.reviewboard.kde.org/r/102732/diff/1/?file=37467#file37467line557>
> >
> > this should remain, so that opening a project that doesn't have the rc
> > file gets one. best might be to move this code into a method called
> > something like "ensureProjectrcFileExists()" and then call it from both of
> > these places.
>
> Giorgos Tsiapaliwkas wrote:
> We have an issue.
> Look at the commit "3a9061a6437221a3c80b16eaf9948b28dcc70e5a" if i do the
> above change then plasmate will not create the .git directory in the right
> place.
>
> I can thing three solutions,
> 1.to have two "plasmateprojectrc" files which will have a different name
> 2.to scan the entire folder for a ".git" dir and if none will be found
> then to create the .git dir
> 3.to add something in the plasmateprojectrc which will act as a flag.
>
> Giorgos Tsiapaliwkas wrote:
> what should i do?
> thanks
are you sure about that? to me it looks like, in the "load local project" case
that putting .plasmaprojectrc in the _same_ directory as the package (which is
what gets loaded) means that it isn't in the same directory as the .git dir.
the only time i can see this causing a problem is when the repository is
something like this:
~/somepath
\-- git/
|-- plasmoidProject/
\-- .git
|-- metadata.desktop
|-- contents/
in that case it will screw up, but it seems quite the corner case. in this case:
~/somepath
\|-- plasmoidProject/
\-- .git
|-- metadata.desktop
|-- contents/
then .plasmaprojectrc will end up in ~/somepath/plasmoidProject and the test
for ~/somepath/plasmoidProject/../.plasmoidprojectrc will fail and it will load
it as an externally loaded (not created by Plasmate) project, no?
- Aaron J.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102732/#review6960
-----------------------------------------------------------
On Sept. 29, 2011, 8:51 a.m., Giorgos Tsiapaliwkas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102732/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2011, 8:51 a.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> Hello,
>
> for the moment the .plasmateprojectrc file exists as a mark for the projects
> created by plasmate.
> We want the file to be created in the creation of the project not in the load
> of the project,the patch does that.
>
> cheers
>
>
> Diffs
> -----
>
> startpage.cpp fc00441
>
> Diff: http://git.reviewboard.kde.org/r/102732/diff/diff
>
>
> Testing
> -------
>
> workinig
>
>
> Thanks,
>
> Giorgos Tsiapaliwkas
>
>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
