----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103393/#review8950 -----------------------------------------------------------
plasma/applets/folderview/folderview.cpp <http://git.reviewboard.kde.org/r/103393/#comment7431> Shouldn't this be done when not connected? i.e. inside the if() on line 409 plasma/applets/folderview/folderview.cpp <http://git.reviewboard.kde.org/r/103393/#comment7430> Have you tested this? I don't think you can pass a variable (m_url) inside a SLOT. - Shantanu Tushar Jha On Dec. 14, 2011, 3:21 a.m., Sujith Haridasan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103393/ > ----------------------------------------------------------- > > (Updated Dec. 14, 2011, 3:21 a.m.) > > > Review request for Plasma. > > > Description > ------- > > Adding patch for the TODO, mentioned in the folderview.cpp file. This patch > looks whether the url is local or remote. If its remote then checks for the > network status of the host machine. If the host machine is not connected to > the network then returns. > > > Diffs > ----- > > plasma/applets/folderview/folderview.cpp 43d0511 > > Diff: http://git.reviewboard.kde.org/r/103393/diff/diff > > > Testing > ------- > > Tested by removing the host from the network and by adding the host to the > network. > > > Thanks, > > Sujith Haridasan > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
