> On Dec. 19, 2011, 2:35 p.m., David Faure wrote: > > kdeui/kernel/kglobalsettings.cpp, line 886 > > <http://git.reviewboard.kde.org/r/103469/diff/2/?file=43867#file43867line886> > > > > I like the idea (KGlobalSettings reparsing configuration), but not the > > implementation (setLanguage(langage)). Can't KLocale get a > > reparseConfiguration() (to reuse the KConfig naming) ?
KLocale::reparseConfiguration() would be just a call to KLocalePrivate::initFormat(), but initFormat is protected. I will have to make it public to use it in KLocale::reparseConfiguration, wouldn't that break binary compatibility? Another alternative is creating a public KLocalePrivate::reparseConfiguration() just to call KLocalePrivate::initFormat(). - Lamarque Vieira ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103469/#review9078 ----------------------------------------------------------- On Dec. 19, 2011, 2:02 p.m., Lamarque Vieira Souza wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103469/ > ----------------------------------------------------------- > > (Updated Dec. 19, 2011, 2:02 p.m.) > > > Review request for kdelibs and Plasma. > > > Description > ------- > > This is patch number 3 to fix bug #289094 (top bar time incorrectly displays > in 24 hour format). The other patches are against plasma-mobile and > kde-workspace (http://git.reviewboard.kde.org/r/103434), all three patches > must be applied to fix the bug. I think this is a much simpler solution than > the one I suggested in http://git.reviewboard.kde.org/r/103434. > > > This addresses bug 289094. > http://bugs.kde.org/show_bug.cgi?id=289094 > > > Diffs > ----- > > kdeui/kernel/kglobalsettings.h cb8f7e2 > kdeui/kernel/kglobalsettings.cpp 819b314 > > Diff: http://git.reviewboard.kde.org/r/103469/diff/diff > > > Testing > ------- > > > Thanks, > > Lamarque Vieira Souza > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
