> On Dec. 23, 2011, 5:40 p.m., Aaron J. Seigo wrote:
> > looks quite straightforward. i'm not overly fond of having "wm console" and 
> > "desktop console" and not being able to switch between them in the UI. it 
> > would be very cool to have the ability to switch modes from the toolbar. 
> > 
> > what would be FANTASTIC is to be able to put blocks of plasma-desktop and 
> > kwin code in the same editor and have it run the JS in the "right" place, 
> > but i think that faces a number of limitations due to the nature of 
> > controlling an out of process app (kwin). either the kwin API would need to 
> > implemented in plasmagenericshell's scripting and in there forward calls on 
> > via DBus (or whatever) or limit it rather unnaturally to blocks of code 
> > that would get executed in their own context (e.g. no variables available 
> > from both a desktop block and a kwin block)
> > 
> > so that seems like something for another day, as it would be quite a bit of 
> > work :)
> > 
> > imho, for now this can go in as-is with the addition of a drop down in the 
> > toolbar to switch between modes easily

> it would be very cool to have the ability to switch modes from the toolbar. 
Yes, that's something I want to add. I thought about to Toggle Buttons in the 
toolbar "Plasma", "KWin" which are mutual exclusive. I just didn't want to work 
on it any more today and wanted to push out the review request :-)

Will implement that after Christmas break :-)

The other idea sounds complicated. Not sure whether that would be possible at 
all without exposing complete KWin internals to D-Bus.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103518/#review9210
-----------------------------------------------------------


On Dec. 23, 2011, 2:24 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103518/
> -----------------------------------------------------------
> 
> (Updated Dec. 23, 2011, 2:24 p.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Description
> -------
> 
> * KWin scripting becomes partly controllable through D-Bus
> * Desktop Scripting Console can control KWin scripts. For that two new 
> methods to PlasmaApp's D-Bus interface are added. If in KWin mode the script 
> is passed to KWin through D-Bus
> * Plasma Desktop Runner gains new keyword "wm console" to start Desktop 
> Scripting Console in KWin mode.
> 
> 
> Diffs
> -----
> 
>   kwin/scripting/scripting.h b0d00f9 
>   kwin/scripting/scripting.cpp 0a71849 
>   plasma/desktop/runners/plasma-desktop/plasma-desktop-runner.h 227748d 
>   plasma/desktop/runners/plasma-desktop/plasma-desktop-runner.cpp 617bc69 
>   plasma/desktop/shell/dbus/org.kde.plasma.App.xml e9b6482 
>   plasma/desktop/shell/interactiveconsole.h f94b997 
>   plasma/desktop/shell/interactiveconsole.cpp 6f2ff75 
>   plasma/desktop/shell/plasmaapp.h 3c7289c 
>   plasma/desktop/shell/plasmaapp.cpp b630225 
> 
> Diff: http://git.reviewboard.kde.org/r/103518/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Desktop Scripting console with KWin integration
>   http://git.reviewboard.kde.org/r/103518/s/379/
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to