----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103545/ -----------------------------------------------------------
Review request for Plasma and Aaron J. Seigo. Description ------- Currently, after Aaron's patch https://projects.kde.org/projects/kde/kde-baseapps/repository/revisions/10a7c8aaa06d73a1415d128f25000f7335a59d25, certain FolderView settings are not changed on the fly (but instead change only after a plasma-desktop restart) after I hit the "Apply" button. E.g. the "Click to enter folder", or "Show Desktop/Home/cutom location", and others. I think this is because the settings are written to disk, but are not applied in configAccepted(). This patch adds a configChanged() call right before the configAccepted() function end. Diffs ----- plasma/applets/folderview/folderview.cpp d620a7d Diff: http://git.reviewboard.kde.org/r/103545/diff/diff Testing ------- Works fine after the patch. Settings are indeed changed after hitting the "Apply" button. I'm not sure, however, whether the configChanged() should go before the timer or after it. My guess is that the timer call is there in order to allow the newly written settings to sync to the hard disk, so I put the call at the very end of the accepted() method. Thanks, Ignat Semenov
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
