-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103595/
-----------------------------------------------------------

Review request for Plasma.


Description
-------

Right-aligned popups are one pixel away from right edge of the screen and 
top-aligned popups (when the panel is on top) are one pixel inside panel. This 
is because the bug in QRect, where right() and bottom() value return value that 
is less than the true value by one. This is a feature-bug that Qt developers 
aren't going to fix because of compatiability reasons. My patch replaces 
rect.right() and rect.bottom() with (rect.x() + rect.width()) and (rect.y() + 
rect.height()) respectively.


Diffs
-----

  plasma/corona.cpp 366a9df 

Diff: http://git.reviewboard.kde.org/r/103595/diff/diff


Testing
-------

Works as expected.


Thanks,

Nikita Churaev

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to