----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103735/#review10269 -----------------------------------------------------------
This review has been submitted with commit c120b69d51f06e41935513d8b164a493dafe9b65 by Ignat Semenov to branch KDE/4.8. - Commit Hook On Jan. 20, 2012, 9:36 a.m., Ignat Semenov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103735/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2012, 9:36 a.m.) > > > Review request for Plasma, Aaron J. Seigo and Marco Martin. > > > Description > ------- > > Currently, the FolderView::IconView::itemSize() method accounts for the > margins only if size.width()>ts.width(), that is, the icon+margins is wider > than the text. However, when ts.width()>size.width(), the margins are not > accounted for, and size.width()=ts.width(). This can be observed easily. The > patch adds those margins to the second operand of the comparison macro. > > > Diffs > ----- > > plasma/applets/folderview/iconview.cpp 09b9c80 > > Diff: http://git.reviewboard.kde.org/r/103735/diff/diff > > > Testing > ------- > > Tested by manually changing the paintItem() code to use the itemSize() rect > and observing the improved behaviour. > > > Thanks, > > Ignat Semenov > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
