> On March 12, 2012, 10:31 a.m., Sebastian Kügler wrote: > > plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml, line 66 > > <http://git.reviewboard.kde.org/r/104226/diff/1/?file=52425#file52425line66> > > > > The word puzzle here is not translatable. You'll need to enclose a full > > string into i18n(), with the current code, translators can't figure out > > what the message is. > > > > Also, appending strings to each other doesn't work, as the word order > > might be different. So you have to identify the cases, and then return a > > completely translated string. > > Viranch Mehta wrote: > For now, I'm dropping i18n() completely on such computed strings.
Fixed it to work in a manner similar to the C++ one. - Viranch ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226/#review11311 ----------------------------------------------------------- On March 13, 2012, 11:14 a.m., Viranch Mehta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104226/ > ----------------------------------------------------------- > > (Updated March 13, 2012, 11:14 a.m.) > > > Review request for Plasma. > > > Description > ------- > > I fixed the QML battery monitor to be fairly usable and this diff merges it > to master. > > > Diffs > ----- > > plasma/generic/applets/CMakeLists.txt 2dedcb2 > plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION > plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION > plasma/generic/applets/batterymonitor/README.txt PRE-CREATION > plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz > PRE-CREATION > plasma/generic/applets/batterymonitor/battery-oxygen.svgz PRE-CREATION > plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION > plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml > PRE-CREATION > plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml > PRE-CREATION > plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml > PRE-CREATION > plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION > plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION > plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2 > plasma/generic/dataengines/powermanagement/powermanagementengine.cpp > 5572fcb > plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 > plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0 > > plasma/generic/dataengines/powermanagement/powermanagementservice.operations > ad1301f > > Diff: http://git.reviewboard.kde.org/r/104226/diff/ > > > Testing > ------- > > Applet and dataengine both tested and work fine. > > > Thanks, > > Viranch Mehta > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
