> On March 18, 2012, 7:57 p.m., Aaron J. Seigo wrote:
> > what is the use case for knowing if it is animated or not? this seems like
> > an internal implementation detail?
>
> David Edmundson wrote:
> I assume it's more for setting whether it animates or not. (when the user
> clicks on the slider, whether it slides to the new value) Tbh, I'm with you
> that it's not needed.
>
> However the gallery is full of
> Slider {
> ....
> animated:true;
> }
>
> and the documentation at the top of this file says:
>
> bool animated
> This property holds if the slider will animate or not when other point is
> clicked,
> and the slider handler is not being dragged. The default value is false.
>
> So it looked to me like it was meant to exist, and was missed off.
>
> Aaron J. Seigo wrote:
> it did exist, but was pulled from the code as it should be an
> implementation detail that is kept consistent within the component set, not
> controlled by the individual application using the components. from irc today:
>
> [10:51] <aseigo> notmart:
> https://git.reviewboard.kde.org/r/104318/#review11571 <--- do you know why
> there is an animated property?
> [10:52] * notmart looks
> [10:52] <notmart> should be definitely be something not controllable
> [10:53] <notmart> aseigo: i'll say, remove it from the documentation
> rather adding in the code right?
> [10:54] <notmart> i think i yanked it in the past but forgot from the docs
> [10:58] <aseigo> cool. that's what i thought but figured i should ask :)
>
> so the right fix would be to just remove the documentation :) please do
> so and commit at your leisure (closing this review in the process) ...
Cool, I should have checked the history.
Make sure Gallery/Sliders.qml is updated too.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104318/#review11571
-----------------------------------------------------------
On March 17, 2012, 7:27 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104318/
> -----------------------------------------------------------
>
> (Updated March 17, 2012, 7:27 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> Add missing property alias "animation" in Slider Plasma Component
>
> Item now matches it's own documentation.
>
>
> Diffs
> -----
>
> plasma/declarativeimports/plasmacomponents/qml/Slider.qml 447dbb1
>
> Diff: http://git.reviewboard.kde.org/r/104318/diff/
>
>
> Testing
> -------
>
> Tested in Component Gallery (which didn't work before!)
>
>
> Thanks,
>
> David Edmundson
>
>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
