-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104413/
-----------------------------------------------------------
Review request for Plasma, Aaron J. Seigo and Fredrik Höglund.
Description
-------
This patch disables action icons if they cover the actual icon. Thus, tthe
buttons being enabled depends on the grid size, the icon size and the svg
margin size.
I've tried a lot of different approaches in order to write the shortest and
most transparent code, hope the current one is fine from this perspective.
Please pay attention to design and incapsulation issues, I'm not a good
designer at all.
This addresses bug 268641.
http://bugs.kde.org/show_bug.cgi?id=268641
Diffs
-----
plasma/applets/folderview/actionoverlay.h e7c1982
plasma/applets/folderview/actionoverlay.cpp 4dd1975
plasma/applets/folderview/iconview.h c76b4f4
plasma/applets/folderview/iconview.cpp 56f1eb8
Diff: http://git.reviewboard.kde.org/r/104413/diff/
Testing
-------
Tested, works.
I still wonder, however, why we can't have a checkbox to disable the dreaded
"+" button.. although the patch submitted in thei review request should go in
regardless of such a checkbox being added because at some icon sizes, the
action icons are a plain annoyance, indeed.
Thanks,
Ignat Semenov
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
