-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104431/#review12430
-----------------------------------------------------------


This review has been submitted with commit 
611c461bcf3687d02a9b1078f1451bc7f81bdd94 by David Edmundson to branch master.

- Commit Hook


On April 6, 2012, 10:20 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104431/
> -----------------------------------------------------------
> 
> (Updated April 6, 2012, 10:20 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> * Remove "runner" from "Nepomuk Desktop Search Runner" as the runner is 
> implied from the context and to bring consistency.
> * Add correct icon for activities runner
> * Use correct case in description of "places" runner.
> * Use correct case in Webshorts runner description
> * Match top and bottom margin sizes. This updates a bodge that removed 2 
> pixels from the top margin to only use 1.
> * Reword "Available Features" to "Available Plugins" for consistency
> * Make the krunner config dialog appear to load slightly faster by loading 
> the list of plugins after we've shown the dialog.
> * Remove undefined (and unused) private method.
> 
> 
> Diffs
> -----
> 
>   krunner/configdialog.h a9c353a 
>   krunner/configdialog.cpp 80485ca 
>   krunner/krunnerdialog.cpp 007887f 
>   plasma/generic/runners/activities/plasma-runner-activityrunner.desktop 
> 853c680 
>   plasma/generic/runners/nepomuksearch/plasma-runner-nepomuksearch.desktop 
> 0319463 
>   plasma/generic/runners/places/plasma-runner-places.desktop b82fa14 
>   plasma/generic/runners/webshortcuts/plasma-runner-webshortcuts.desktop 
> f234b4f 
> 
> Diff: http://git.reviewboard.kde.org/r/104431/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to