----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104612/#review12497 -----------------------------------------------------------
Thanks for the patch! Little changes though, check the comments below. Once you're done, this can go in :) shells/newshell/mainwindow.h <http://git.reviewboard.kde.org/r/104612/#comment9804> remove extra whitespace shells/newshell/mainwindow.cpp <http://git.reviewboard.kde.org/r/104612/#comment9805> Its better to have a single method called toggleFullscreen which turns on and off the fullscreen, instead of having two separate functions shells/newshell/package/contents/ui/mediacenter.qml <http://git.reviewboard.kde.org/r/104612/#comment9806> Once you have only one slot toggleFullscreen(), you don't need all this logic inside QML. This should just have a call to toggleFullscreen() - Shantanu Tushar Jha On April 16, 2012, 5:42 a.m., nancy kumari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104612/ > ----------------------------------------------------------- > > (Updated April 16, 2012, 5:42 a.m.) > > > Review request for Plasma. > > > Description > ------- > > Added the feature to change the mode of media center from default to full > screen and vice-versa. A button has been added at top left corner to enable > the above said feature, clicking on which does the appropriate changes. > > > Diffs > ----- > > shells/newshell/mainwindow.h d6d4405 > shells/newshell/mainwindow.cpp bfafc34 > shells/newshell/package/contents/ui/mediacenter.qml 67106ff > > Diff: http://git.reviewboard.kde.org/r/104612/diff/ > > > Testing > ------- > > Tested by running the added feature in trunk. It works fine. > > > Thanks, > > nancy kumari > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
