----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105032/#review14399 -----------------------------------------------------------
publisher/remoteinstaller/remoteinstaller.cpp <http://git.reviewboard.kde.org/r/105032/#comment11363> Don't do this. What if someone uses your class and passes a qobject that isn't a qwidget as the parent? You'll get a crash despite them using your API "correctly". Change constructor to: RemoteInstaller::RemoteInstaller(const QString& username, const QString& hostname,const QString& source, QWidget* parent): QObject(parent), m_widget(parent) { ... } . - David Edmundson On June 3, 2012, 9:32 a.m., Giorgos Tsiapaliwkas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105032/ > ----------------------------------------------------------- > > (Updated June 3, 2012, 9:32 a.m.) > > > Review request for Plasma. > > > Description > ------- > > Hello, > > in terietor/remoteinstaller I have create a remote installer. > The goal is to install the projects remotely to another computer. > > You access the remote install either inside plasmate or using the > plasmaremoteinstaller binary. > > > Diffs > ----- > > CMakeLists.txt 12f8a3a > publisher/publisher.h 5f40ae0 > publisher/publisher.cpp fd87364 > publisher/remoteinstaller/remoteinstaller.h PRE-CREATION > publisher/remoteinstaller/remoteinstaller.cpp PRE-CREATION > publisher/remoteinstaller/remoteinstaller.ui PRE-CREATION > publisher/remoteinstaller/remoteinstallerdialog.h PRE-CREATION > publisher/remoteinstaller/remoteinstallerdialog.cpp PRE-CREATION > publisher/remoteinstaller/standalone/main.cpp PRE-CREATION > publisher/remoteinstaller/standalone/plasmaremoteinstaller.h PRE-CREATION > publisher/remoteinstaller/standalone/plasmaremoteinstaller.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/105032/diff/ > > > Testing > ------- > > I couldn't find any bugs in the remote installer, but the proccess fails > during KIO::copy. > Apparently I am not writing correct something in the fish protocol. > Right now the remote installer tries to do the above > > KIO::copy("/home/terietor/.kde4/share/apps/plasmate/project, > "fish://user@ip/home/user") > > but it fails > > > Thanks, > > Giorgos Tsiapaliwkas > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
