----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105163/#review14504 -----------------------------------------------------------
Ship it! Ship It! - David Edmundson On June 6, 2012, 2:28 p.m., Aurélien Gâteau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105163/ > ----------------------------------------------------------- > > (Updated June 6, 2012, 2:28 p.m.) > > > Review request for Plasma. > > > Description > ------- > > When the widgets use the button background frame, use buttonTextColor. When > they do not use any background frame, use textColor. > This avoids unreadable text with Oxygen, as visible on screenshots. > > > Diffs > ----- > > > plasma/declarativeimports/plasmacomponents/platformcomponents/touch/ToolButton.qml > 71629fc > plasma/declarativeimports/plasmacomponents/qml/TabButton.qml 0131b12 > plasma/declarativeimports/plasmacomponents/qml/ToolButton.qml a10e0bf > > Diff: http://git.reviewboard.kde.org/r/105163/diff/ > > > Testing > ------- > > Run Plasma widget gallery, before and after the patch. > > > Screenshots > ----------- > > before > http://git.reviewboard.kde.org/r/105163/s/598/ > after > http://git.reviewboard.kde.org/r/105163/s/599/ > > > Thanks, > > Aurélien Gâteau > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel