> On June 14, 2012, 6:18 p.m., Aaron J. Seigo wrote: > > plasma/declarativeimports/plasmacomponents/qml/private/DualStateButton.qml, > > lines 77-78 > > <http://git.reviewboard.kde.org/r/105232/diff/1/?file=67422#file67422line77> > > > > loos like this will work but i dislike how shadowLoader.state is being > > set all over the place in a rather procedural manner. much nicer imho would > > be sth like: > > > > Loader { > > id: shadowLoader > > anchors.fill: surfaceLoader > > state: (duableButton.enabled && dualButton.focus) ? "hover" : > > "shadow" > > } > > > > and then do the right thing in Keys.onSpacePressed, > > Keys.onReturnPressed, etc. > > > > this would also get rid of the entered() function and maybe even clean > > up the MouseArea below as well. > > > > to me this would just feel "more QML" > > > > Marco: what do you think?
yeah, i agree. to me apart this small issue the change in behaviour is correct, so correct it and can be pushed - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105232/#review14727 ----------------------------------------------------------- On June 12, 2012, 10:25 p.m., Johannes Tröscher wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105232/ > ----------------------------------------------------------- > > (Updated June 12, 2012, 10:25 p.m.) > > > Review request for Plasma. > > > Description > ------- > > this will enable the highlight on a dualstatebutton (like a checkbox) also if > the button has keyboardfocus. > > > Diffs > ----- > > plasma/declarativeimports/plasmacomponents/qml/private/DualStateButton.qml > 1579e88 > > Diff: http://git.reviewboard.kde.org/r/105232/diff/ > > > Testing > ------- > > tested, works > > > Thanks, > > Johannes Tröscher > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
