----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105405/#review16103 -----------------------------------------------------------
thanks, wouldn;t have remembered ;) the changes seems good, but i'm not sure about giving kickoff a copy of the tabbar. any reason this is not proposed as a patch for the tabbar component itself? - Marco Martin On July 1, 2012, 8:42 p.m., Greg T wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105405/ > ----------------------------------------------------------- > > (Updated July 1, 2012, 8:42 p.m.) > > > Review request for Plasma, Marco Martin and Martin Gräßlin. > > > Description > ------- > > Heda, > This patch addresses the layout of the tab bar. The tab buttons are now sized > depending of their text width. > > I just copied the tabbar code from kde-runtime and exchanged taskbarLayout. > My main question is: Can I do this more elegantly without copying TabBar.qml? > > > Diffs > ----- > > plasma/desktop/applets/kickoff/package/contents/ui/KickoffTabBar.qml > PRE-CREATION > plasma/desktop/applets/kickoff/package/contents/ui/Private/TabBarLayout.qml > PRE-CREATION > plasma/desktop/applets/kickoff/package/contents/ui/kickoff.qml 4d53208 > > Diff: http://git.reviewboard.kde.org/r/105405/diff/ > > > Testing > ------- > > > Thanks, > > Greg T > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
