----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106125/#review18014 -----------------------------------------------------------
Review: This doesn't really fix 297842, or does it? If I understand the reporter correctly, he wants to move with Up/Down keys in the search view as soon as he enters a search query. With your patch applied I still have to hit the tab key first. Can you set the focus automatically on the view? - Greg T On Aug. 23, 2012, 12:28 a.m., Richard Stockton wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106125/ > ----------------------------------------------------------- > > (Updated Aug. 23, 2012, 12:28 a.m.) > > > Review request for Plasma, Lamarque Vieira Souza and Martin Gräßlin. > > > Description > ------- > > Keyboard control of Kickoff-Widget GUI, using arrow keys and Qt::Key_Tab. > This version combines https://git.reviewboard.kde.org/r/104422/ and > https://git.reviewboard.kde.org/r/106123/, preventing a repeat of bug 297842 > when the feature (RFE bug 276932) is added to 4.9 and Trunk. > > > This addresses bugs 276932 and 297842. > http://bugs.kde.org/show_bug.cgi?id=276932 > http://bugs.kde.org/show_bug.cgi?id=297842 > > > Diffs > ----- > > plasma/desktop/applets/kickoff/ui/launcher.cpp 3662ef0 > plasma/desktop/applets/kickoff/ui/searchbar.cpp 6937f93 > > Diff: http://git.reviewboard.kde.org/r/106125/diff/ > > > Testing > ------- > > #1 Arrow key movement among programs in the flipscrollview (Right, back to > Left, and Up/Down). Activbation of highlighted/selected programs. > #2 Search bar entry, movement into View of matches using the Tab key. Move > among multiple matching prgrams via arrow keys. Tab goes back to the search > TextEdit field, allowing the search to be modified; and it is highlighted, > allowing the search text to be deleted. > #3 an empty search text field re-shows the tab bar and flipscrollview; tab > selection is again enabled via left/right arrow keys. > > NOTE: It requires 2, even 3 Tabs to get exactly where you want to be via > keyboard. Up/Down arrows are sometimes ignored, because the MVC Controller > has insufficient knowledge of where you came from, and often tries to send > your keystroke to an invisible, non-responsive View. IMO, Re-design or total > replacement (Kickoff-QML) IS appropriate. > > But it works.... sort of. > > > Thanks, > > Richard Stockton > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
