----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106504/#review19156 -----------------------------------------------------------
Why the "if(m_favicon)"? You could just delete m_favicon and set it to 0 (or better, NULL), as "delete NULL" is a noop. Apart from this, I think it's ok :) - Marco Gulino On Sept. 19, 2012, 11:21 a.m., Giorgos Tsiapaliwkas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106504/ > ----------------------------------------------------------- > > (Updated Sept. 19, 2012, 11:21 a.m.) > > > Review request for Plasma. > > > Description > ------- > > krunner crashes due to > kde-workspace/plasma/generic/runners/bookmarks/browsers/firefox.cpp > (Firefox::teardown()). > > This patch solves the issue. > > Also I fixed the indentation and a mem leak. > > > Diffs > ----- > > plasma/generic/runners/bookmarks/browsers/firefox.cpp 4dc02e3 > > Diff: http://git.reviewboard.kde.org/r/106504/diff/ > > > Testing > ------- > > since yesterday that I use the patch I haven't see any crashes > > > Thanks, > > Giorgos Tsiapaliwkas > >
_______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
