----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106768/#review20082 -----------------------------------------------------------
That looks a bit better in my opinion. I would change/fix the wording for the dashboard screen locker a bit "Click configure to find more about it!" doesn't sound quite right for a tooltip, maybe something like "Click the configure button to set it up" or something? - Jeremy Paul Whiting On Oct. 8, 2012, 3:43 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106768/ > ----------------------------------------------------------- > > (Updated Oct. 8, 2012, 3:43 p.m.) > > > Review request for Plasma and KDE Usability. > > > Description > ------- > > After complaining about this KCM last week, I wanted to give it a try to > improve it a little. I think that the biggest stopper here is wanting to keep > the screensaver here, because we've ended up with a 3-head monster: > * simple locker > * plasma-based locker > * xscreensavers > > Since it seems it's something we may want for the moment. IMHO, we should end > up with the Plasma-based option alone. I just tried to re-organize it in a > way I like a little better. > > What I did > - I aligned the locking labels to the left, like the Form Layout suggests. It > creates a small puzzle, I'm unsure if that's a problem. > - I added toolTips and whatsThis in the locking type option buttons, so that > we can at least figure out what will happen when we lock. > > > Diffs > ----- > > kcontrol/screensaver/screensaver.ui 6524e27 > kcontrol/screensaver/scrnsave.cpp 0125620 > > Diff: http://git.reviewboard.kde.org/r/106768/diff/ > > > Testing > ------- > > just messed with it for a while. > > > Screenshots > ----------- > > result > http://git.reviewboard.kde.org/r/106768/s/758/ > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
